Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for translations #7

Open
cfoellmann opened this issue Aug 22, 2018 · 2 comments
Open

Support for translations #7

cfoellmann opened this issue Aug 22, 2018 · 2 comments

Comments

@cfoellmann
Copy link

this "library" should support translations. You did get it most of the way but it is not quiet ready.
I can pitch in just give me a sign that you are open for it.
@dcooney
Copy link
Owner

dcooney commented Aug 22, 2018

Sounds good, thanks!

@cfoellmann
Copy link
Author

There is one big issue with translations in a library that will be included in a wp plugin.
You either need to include the po/mo files with the library package or set the text-domain to the parent plugin. That way the strings will be included in the plugins translations.

OR you only use translation strings from wp core. I think it is possible with this library. See my PR. #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dcooney @cfoellmann