From 8baf4f643c8044b4c99100c38a2e9ac9e6ed26d1 Mon Sep 17 00:00:00 2001
From: Jonathan Desrosiers <desrosj@git.wordpress.org>
Date: Fri, 22 Sep 2023 13:55:14 +0000
Subject: [PATCH] Build/Test Tools: Update the environment variable for
 skipping browser binaries.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This changes the environment variable used in GitHub Action workflows to skip downloading the browser binary that’s a peer dependency when it’s not needed.

In [56647], the version of `puppeteer` peer-dependency was bumped to `>= 20.0.0`. Starting in version `20.0.0`, puppeteer switched to using Chrome for testing instead of Chromium. With this release, the `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` environment variable was removed in favor of the more generic `PUPPETEER_SKIP_DOWNLOAD`.

All workflows that do not need a browser binary now contain the correct `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` variable.

Follow up to [56647].

See #58863.

git-svn-id: https://develop.svn.wordpress.org/trunk@56659 602fd350-edb4-49c9-b593-d223f7449a82
---
 .github/workflows/coding-standards.yml  | 2 +-
 .github/workflows/phpunit-tests-run.yml | 2 +-
 .github/workflows/test-coverage.yml     | 2 +-
 .github/workflows/test-npm.yml          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/coding-standards.yml b/.github/workflows/coding-standards.yml
index 3a2061c113a89..3cf5836f833fd 100644
--- a/.github/workflows/coding-standards.yml
+++ b/.github/workflows/coding-standards.yml
@@ -143,7 +143,7 @@ jobs:
     timeout-minutes: 20
     if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
     env:
-      PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+      PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
     steps:
       - name: Checkout repository
diff --git a/.github/workflows/phpunit-tests-run.yml b/.github/workflows/phpunit-tests-run.yml
index 96280b84aa28b..54c34c6511e00 100644
--- a/.github/workflows/phpunit-tests-run.yml
+++ b/.github/workflows/phpunit-tests-run.yml
@@ -51,7 +51,7 @@ env:
   LOCAL_DB_VERSION: ${{ inputs.db-version }}
   LOCAL_PHP_MEMCACHED: ${{ inputs.memcached }}
   PHPUNIT_CONFIG: ${{ inputs.phpunit-config }}
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:
   # Runs the PHPUnit tests for WordPress.
diff --git a/.github/workflows/test-coverage.yml b/.github/workflows/test-coverage.yml
index 3f4c245cd1083..01db2eec5c966 100644
--- a/.github/workflows/test-coverage.yml
+++ b/.github/workflows/test-coverage.yml
@@ -29,7 +29,7 @@ on:
 permissions: {}
 
 env:
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
   LOCAL_PHP: '7.4-fpm'
   LOCAL_PHP_XDEBUG: true
   LOCAL_PHP_XDEBUG_MODE: 'coverage'
diff --git a/.github/workflows/test-npm.yml b/.github/workflows/test-npm.yml
index 45e04b4d60d97..7c6f018f15b84 100644
--- a/.github/workflows/test-npm.yml
+++ b/.github/workflows/test-npm.yml
@@ -38,7 +38,7 @@ concurrency:
 permissions: {}
 
 env:
-  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
+  PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
 
 jobs:
   # Verifies that installing npm dependencies and building WordPress works as expected.