Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing against stable (but not HEAD) #38

Closed
rfay opened this issue May 23, 2024 · 5 comments
Closed

Tests are failing against stable (but not HEAD) #38

rfay opened this issue May 23, 2024 · 5 comments

Comments

@rfay
Copy link
Member

rfay commented May 23, 2024

tests are failing against stable. I don't know why they're not failing against HEAD.

Please fix, thanks @mkalkbrenner !

@rfay
Copy link
Member Author

rfay commented May 23, 2024

I'm not sure, but this could be related to ddev/github-action-add-on-test#31

@julienloizelet
Copy link

julienloizelet commented May 24, 2024

Hi there,
I see that the permissions are not the right ones to use v2:
https://github.com/ddev/ddev-solr/blob/main/.github/workflows/tests.yml#L24

It should be actions:write .

Thanks

@mkalkbrenner
Copy link
Collaborator

mkalkbrenner commented May 24, 2024

The tests started to fail 2 days ago without any change to ddev-solr. In fact, the tests themselves don't fail.

@rfay As the yaml file is derived from the template, is there a fix for the template?

@julienloizelet
Copy link

For the past 2 days, the test action is trying to keep alive the repo on every run (using this keepalive action).

But the keepalive action needs actions:write permissions.

(Template has been modified: https://github.com/ddev/ddev-addon-template/blob/main/.github/workflows/tests.yml#L24)

@rfay
Copy link
Member Author

rfay commented May 25, 2024

Yay, fixed, thanks! https://github.com/ddev/ddev-solr/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants