Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments enabled but formatter drops comments #24

Open
company-jcup opened this issue Mar 1, 2022 · 1 comment · May be fixed by #31
Open

Comments enabled but formatter drops comments #24

company-jcup opened this issue Mar 1, 2022 · 1 comment · May be fixed by #31
Assignees
@de-jcup
Labels
bug Something isn't working

Comments

@company-jcup
Copy link

When comments are enabled in preferences and I press "CTRL+SHIFT+F" the comments vanish...
@de-jcup de-jcup self-assigned this May 5, 2022
@de-jcup de-jcup added the bug Something isn't working label May 5, 2022
@de-jcup de-jcup added this to the 1.2.1 milestone May 5, 2022
@company-jcup
Copy link
Author

It seems that the jackson library, which is used for JSON pretty printing, does drop the comments, even when the feature "allow comments" is enabled

de-jcup added a commit that referenced this issue Oct 12, 2023
@de-jcup
Introduce comment history to keep comments #24
b517cdc
@de-jcup de-jcup linked a pull request Oct 12, 2023 that will close this issue
Draft
@de-jcup de-jcup removed this from the 1.3.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce comment history to keep comments #24 de-jcup/eclipse-hijson-editor
2 participants
@de-jcup @company-jcup