From e54212c31b4a8fa4a94fa0a634ed0cdd898aa638 Mon Sep 17 00:00:00 2001
From: Jeff Davidson <jpd@google.com>
Date: Wed, 19 Jun 2024 11:43:34 -0700
Subject: [PATCH] Hide more guess queue functionality when queue is disabled.

- Disable guess notifications
- Hide extraneous columns from the guess queue page
- Rename "Guess queue" to "Answer log" and "Guesses" to "Answers"

Fixes #2168
---
 imports/client/components/GuessQueuePage.tsx  | 99 ++++++++++++-------
 imports/client/components/HuntNav.tsx         |  6 +-
 .../client/components/NotificationCenter.tsx  |  1 +
 3 files changed, 66 insertions(+), 40 deletions(-)

diff --git a/imports/client/components/GuessQueuePage.tsx b/imports/client/components/GuessQueuePage.tsx
index 074df3166..01a575014 100644
--- a/imports/client/components/GuessQueuePage.tsx
+++ b/imports/client/components/GuessQueuePage.tsx
@@ -52,17 +52,17 @@ import { mediaBreakpointDown } from "./styling/responsive";
 
 const compactViewBreakpoint: Breakpoint = "md";
 
-const StyledTable = styled.div`
+const StyledTable = styled.div<{ $hasGuessQueue: boolean }>`
   display: grid;
   grid-template-columns:
     [timestamp] auto
     [submitter] minmax(auto, 8em)
     [puzzle] minmax(10em, auto)
     [answer] minmax(10em, auto)
-    [direction] minmax(6em, auto)
-    [confidence] minmax(6em, auto)
+    ${(props) => props.$hasGuessQueue && "[direction] minmax(6em, auto)"}
+    ${(props) => props.$hasGuessQueue && "[confidence] minmax(6em, auto)"}
     [status] auto
-    [actions] auto;
+    ${(props) => props.$hasGuessQueue && "[actions] auto"};
   border-bottom: 1px solid #ddd;
   ${mediaBreakpointDown(
     compactViewBreakpoint,
@@ -316,32 +316,40 @@ const GuessBlock = React.memo(
           </OverlayTrigger>{" "}
           <PuzzleAnswer answer={guess.guess} breakable indented />
         </StyledGuessCell>
-        <StyledGuessDetails>
-          <StyledGuessDetailWithLabel>
-            <StyledGuessDetailLabel>Solve direction</StyledGuessDetailLabel>
-            <StyledGuessDirection
-              id={`guess-${guess._id}-direction`}
-              value={guess.direction}
-            />
-          </StyledGuessDetailWithLabel>
-          <StyledGuessDetailWithLabel>
-            <StyledGuessDetailLabel>Confidence</StyledGuessDetailLabel>
-            <StyledGuessConfidence
-              id={`guess-${guess._id}-confidence`}
-              value={guess.confidence}
-            />
-          </StyledGuessDetailWithLabel>
-        </StyledGuessDetails>
+        {hunt.hasGuessQueue && (
+          <StyledGuessDetails>
+            <StyledGuessDetailWithLabel>
+              <StyledGuessDetailLabel>Solve direction</StyledGuessDetailLabel>
+              <StyledGuessDirection
+                id={`guess-${guess._id}-direction`}
+                value={guess.direction}
+              />
+            </StyledGuessDetailWithLabel>
+            <StyledGuessDetailWithLabel>
+              <StyledGuessDetailLabel>Confidence</StyledGuessDetailLabel>
+              <StyledGuessConfidence
+                id={`guess-${guess._id}-confidence`}
+                value={guess.confidence}
+              />
+            </StyledGuessDetailWithLabel>
+          </StyledGuessDetails>
+        )}
         <StyledCell>
           <GuessState id={`guess-${guess._id}-state`} state={guess.state} />
         </StyledCell>
-        <StyledCell>
-          {canEdit && guess.state !== "pending" && (
-            <Button variant="outline-secondary" size="sm" onClick={markPending}>
-              Return to queue
-            </Button>
-          )}
-        </StyledCell>
+        {hunt.hasGuessQueue && (
+          <StyledCell>
+            {canEdit && guess.state !== "pending" && (
+              <Button
+                variant="outline-secondary"
+                size="sm"
+                onClick={markPending}
+              >
+                Return to queue
+              </Button>
+            )}
+          </StyledCell>
+        )}
         {guess.additionalNotes && (
           <Markdown as={StyledAdditionalNotes} text={guess.additionalNotes} />
         )}
@@ -355,12 +363,23 @@ const GuessQueuePage = () => {
   const [searchParams, setSearchParams] = useSearchParams();
   const searchString = searchParams.get("q") ?? "";
 
-  useBreadcrumb({ title: "Guess queue", path: `/hunts/${huntId}/guesses` });
-
   const guessesLoading = useTypedSubscribe(guessesForGuessQueue, { huntId });
   const loading = guessesLoading();
 
   const hunt = useTracker(() => Hunts.findOne({ _id: huntId }), [huntId]);
+
+  const pageTitle = useTracker(() => {
+    if (loading || !hunt) {
+      return "Loading...";
+    } else if (hunt.hasGuessQueue) {
+      return "Guess queue";
+    } else {
+      return "Answer log";
+    }
+  }, [hunt, loading]);
+
+  useBreadcrumb({ title: pageTitle, path: `/hunts/${huntId}/guesses` });
+
   const guesses = useTracker(
     () =>
       loading
@@ -499,7 +518,7 @@ const GuessQueuePage = () => {
 
   return (
     <div>
-      <h1>Guess queue</h1>
+      <h1>{pageTitle}</h1>
       <FormGroup className="mb-3">
         <InputGroup>
           <FormControl
@@ -516,20 +535,24 @@ const GuessQueuePage = () => {
           </Button>
         </InputGroup>
       </FormGroup>
-      <StyledTable>
+      <StyledTable $hasGuessQueue={hunt.hasGuessQueue}>
         <StyledHeaderRow>
           <StyledHeader>Time</StyledHeader>
           <StyledHeader>Submitter</StyledHeader>
           <StyledHeader>Puzzle</StyledHeader>
           <StyledHeader>Answer</StyledHeader>
-          <OverlayTrigger placement="top" overlay={directionTooltip}>
-            <StyledHeader>Direction</StyledHeader>
-          </OverlayTrigger>
-          <OverlayTrigger placement="top" overlay={confidenceTooltip}>
-            <StyledHeader>Confidence</StyledHeader>
-          </OverlayTrigger>
+          {hunt.hasGuessQueue && (
+            <>
+              <OverlayTrigger placement="top" overlay={directionTooltip}>
+                <StyledHeader>Direction</StyledHeader>
+              </OverlayTrigger>
+              <OverlayTrigger placement="top" overlay={confidenceTooltip}>
+                <StyledHeader>Confidence</StyledHeader>
+              </OverlayTrigger>
+            </>
+          )}
           <StyledHeader>Status</StyledHeader>
-          <StyledHeader>&nbsp;</StyledHeader>
+          {hunt.hasGuessQueue && <StyledHeader>&nbsp;</StyledHeader>}
         </StyledHeaderRow>
         {filteredGuesses(guesses, puzzles).map((guess) => {
           return (
diff --git a/imports/client/components/HuntNav.tsx b/imports/client/components/HuntNav.tsx
index 0e25001d7..32457183e 100644
--- a/imports/client/components/HuntNav.tsx
+++ b/imports/client/components/HuntNav.tsx
@@ -167,10 +167,12 @@ const HuntNav = () => {
 
         <StyledPuzzleListLinkAnchor
           to={`/hunts/${huntId}/guesses`}
-          title="Guess queue"
+          title={hunt.hasGuessQueue ? "Guess queue" : "Answer log"}
         >
           <MenuIcon icon={faReceipt} />
-          <StyledPuzzleListLinkLabel>Guesses</StyledPuzzleListLinkLabel>
+          <StyledPuzzleListLinkLabel>
+            {hunt.hasGuessQueue ? "Guesses" : "Answers"}
+          </StyledPuzzleListLinkLabel>
         </StyledPuzzleListLinkAnchor>
 
         <StyledPuzzleListLinkAnchor
diff --git a/imports/client/components/NotificationCenter.tsx b/imports/client/components/NotificationCenter.tsx
index 040d709c5..01c82c50d 100644
--- a/imports/client/components/NotificationCenter.tsx
+++ b/imports/client/components/NotificationCenter.tsx
@@ -959,6 +959,7 @@ const NotificationCenter = () => {
     const hunt = hunts.get(g.hunt);
     const puzzle = puzzles.get(g.puzzle);
     if (!hunt || !puzzle) return;
+    if (!hunt.hasGuessQueue) return;
     messages.push(
       <GuessMessage
         key={g._id}