Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tests are missing negative tests and test-vectors #442

Open
cgrigis opened this issue Sep 7, 2020 · 2 comments
Open

The tests are missing negative tests and test-vectors #442

cgrigis opened this issue Sep 7, 2020 · 2 comments
Assignees
@K1li4nL
Labels
enhancement

Comments

@cgrigis
Copy link
Collaborator

cgrigis commented Sep 7, 2020 •
edited
Loading

Security Code Review observation:

For example, it seems the shuffle tests are not testing the verification of a wrong shuffle nor providing test-vectors.
@K1li4nL K1li4nL self-assigned this Mar 17, 2024
@AnomalRoil AnomalRoil linked a pull request Mar 18, 2024 that will close this issue
Add negative tests shuffle package #503
Merged
@K1li4nL K1li4nL removed a link to a pull request Mar 18, 2024
Add negative tests shuffle package #503
Merged
@K1li4nL
Copy link
Contributor

K1li4nL commented Mar 21, 2024 •
edited
Loading

At least the following packages are missing negatives:

  • shuffle
  • proof/deniable
  • proof/proof
  • proof/dleq/dleq
  • sign/anon (has no test)
  • sign/bdn
  • sign/cosi
  • sign/schnorr
  • sign/tbls

@K1li4nL K1li4nL removed their assignment Mar 25, 2024
@pierluca
Copy link
Contributor

@K1li4nL added you back to discuss (when you're back) what we can do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@K1li4nL K1li4nL

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pierluca @cgrigis @K1li4nL