Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test under specific time conditions on FE2 #1734

Closed
matteosz opened this issue Feb 6, 2024 · 0 comments · Fixed by #1766
Closed

Failing test under specific time conditions on FE2 #1734

matteosz opened this issue Feb 6, 2024 · 0 comments · Fixed by #1766
Assignees
@quadcopterman
Labels
bug Something isn't working fe2-android good first issue Good for newcomers

Comments

@matteosz
Copy link
Contributor

matteosz commented Feb 6, 2024

Description (Actual behavior)

The test cannotChooseStartTimeTooFarInPast (ElectionSetupFragmentTest.kt) fails consistently when executed between 00:00 and 00:09am.

Expected behavior

The test shouldn't be failing anytime.

How to reproduce

Execute this test in the specified time.

Impact

Minimal to none impact (time window of the test failing is late in the night and narrow)

Possible root cause

There are 2 possibilities to investigate:

  1. The logic tested is not robust in the time going during 00:00 and 00:09. This means that the test discovered an implementation bug and it should be fixed
  2. The test logic is flaky and doesn't reproduce an expected behaviour
@matteosz matteosz added bug Something isn't working good first issue Good for newcomers fe2-android labels Feb 6, 2024
@matteosz matteosz changed the title Failing test under specific conditions on FE2 Failing test under specific time conditions on FE2 Feb 6, 2024
quadcopterman added a commit that referenced this issue Feb 28, 2024
@quadcopterman
Finally solved issue #1734
d223859
@quadcopterman quadcopterman self-assigned this Feb 28, 2024
@quadcopterman quadcopterman linked a pull request Mar 4, 2024 that will close this issue
Finally solved issue #1734 #1766
Merged
@quadcopterman quadcopterman mentioned this issue Mar 4, 2024
Merged
quadcopterman added a commit that referenced this issue Mar 5, 2024
@quadcopterman
Merge pull request #1766 from dedis/work-fe2-johan
d372da6 
Finally solved issue #1734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quadcopterman quadcopterman

Labels
bug Something isn't working fe2-android good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finally solved issue #1734 dedis/popstellar
2 participants
@matteosz @quadcopterman