Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node 16 #24

Open
paullatzelsperger opened this issue Oct 11, 2022 · 5 comments · May be fixed by #30 or #39
Open

Update to Node 16 #24

paullatzelsperger opened this issue Oct 11, 2022 · 5 comments · May be fixed by #30 or #39

Comments

@paullatzelsperger
Copy link

paullatzelsperger commented Oct 11, 2022

We're using this action in our project and I noticed that Github Actions issues warnings stating that Node 12 does not receive support anymore as of April 2022, see Github Blog.

I think it's as easy as replacing

runs:
  using: 'node12'
  main: 'index.js'

with

runs:
  using: 'node16'
  main: 'index.js'

in action.yml.

@karl-johan-grahn
Copy link

Our action started to hang with Waiting for status to be reported, will change to node16 and see if it makes any difference

@karl-johan-grahn karl-johan-grahn mentioned this issue Oct 14, 2022
@karl-johan-grahn
Copy link

I was using the name field for one job which caused this, removing it fixed it 🤯

@benelan
Copy link

benelan commented Nov 8, 2022

It seems like this repo is no longer maintained. Luckily it's a small action and I was able to clean it up and add it to a workflow using actions/github-script. Here is an example:

https://github.com/Esri/calcite-design-system/blob/dev/.github/workflows/pr-untruncated.yml

The options in the usage example from this repo's readme would go here like this:

const REGEX = new RegExp("([a-z])+\/([a-z])+");
const MIN_LENGTH = 5;
const MAX_LENGTH = 20;
const ALLOWED_PREFIXES = ["feature", "fix", "JIRA"];
const DISALLOWED_PREFIXES = ["feat/", "hotfix"]; 
const PREFIX_CASE_SENSITIVE = false;

@jonbrooks jonbrooks linked a pull request Mar 30, 2023 that will close this issue
@DavideViolante DavideViolante linked a pull request May 6, 2024 that will close this issue
@DavideViolante
Copy link

@deepakputhraya #39 please take a look at this issue and related PR. Thanks

@kishaningithub
Copy link

We need node 20 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants