Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I suggest to need to change some variables. #85

Open
hsnks100 opened this issue Jul 25, 2023 · 0 comments
Open

I suggest to need to change some variables. #85

hsnks100 opened this issue Jul 25, 2023 · 0 comments

Comments

@hsnks100
Copy link

Thank you for vdk.

Some functions of vdk used to packet []byte. for example) func ParseSliceHeaderFromNALU(packet []byte) (sliceType SliceType, err error)

func ParseSliceHeaderFromNALU(packet []byte) (sliceType SliceType, err error) {

These functions expect the input arguments to be in the form of an rbsp from the h264 specification.
rbsp is pre-processed packet (emulation prevention byte).

I think I have to remove emulation prevention byte from NALU packet because of NALU is not rbsp.
Therefore, In order to notice It is need to remove emulation prevention byte, I suggest to rename of some functions of parameter that packet -> rbsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant