From 53bb5bb9f46478ad8e6dfeb1467cdaa8b7c1c6b4 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Thu, 3 Nov 2022 16:58:51 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- init_code.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/init_code.py b/init_code.py index db14b49..d3552a9 100644 --- a/init_code.py +++ b/init_code.py @@ -27,7 +27,26 @@ def load_model(infile): os.makedirs(tmp_dir) with tarfile.open(infile.name) as tar: - tar.extractall(path=tmp_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=tmp_dir) model = keras.models.load_model(os.path.join(tmp_dir, 'SavedModel'))