-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limitation of dg::TopometricPose #28
Comments
I agree that Anyway, let's resolve your arguments.
|
dg::TopometricPose::edge_idx need to be revised. |
I found out that currently two concepts are mixed, making problem difficult, and it's better to consider them separately. Current definition of dg::TopometricPose is from the robot's or object's point of view and is very useful for navigation or figuring out where we are going. However, it can be problematic to refer to the location on the map. |
OK. I see. The edge_idx focuses more on connectivity of the Edge to the Node, while the Edge ID is independent to the Node. I will follow the edge_idx concept. |
I change my opinion to keep the current structure of dg::TopometricPose and leave the problem of locating point on a map as an open problem. We can use dg::LotLon (metric position) temporarily to locate points. @seohyunatwork I agree with replacing Edge index by Edge ID (if it is not high burden). It will be more convenient for Guidance module and match well with the revised Map and Node & Edge definitions. Also, I suggest to extend current dg::TopometricPose to include heading offset info. I tried to find examples of location representation in topolmetric maps in the literature and I found one up to now:
-> It's the same with ours except that the heading info is missing in dg::TopometricPose. |
I left the above comment before reading @seohyunatwork's last comment. However, I think Edge ID is better than Edge idx anyway. |
We discussed this issue in offline and agreed to keep the current implementation for a while and leave this issue as open. |
generalization issue related to dg::TopometricPose
The text was updated successfully, but these errors were encountered: