From ba169a39934a19bc1b6a6984c7d2e376c192b116 Mon Sep 17 00:00:00 2001
From: Chip Kent <chipkent@deephaven.io>
Date: Tue, 30 Apr 2024 14:17:41 -0600
Subject: [PATCH] Made the versions easier to update.

---
 .github/workflows/build-and-publish.yml | 6 ------
 dhib_env.py                             | 7 +++++--
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/build-and-publish.yml b/.github/workflows/build-and-publish.yml
index 32a6f39f..c335ecfb 100644
--- a/.github/workflows/build-and-publish.yml
+++ b/.github/workflows/build-and-publish.yml
@@ -22,17 +22,11 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v1
-    # TODO: remove
-    - name: DEBUG
-      run: pwd
     - name: Build
       run: |
         cd ibwhl
         docker-compose -f "docker-compose.yml" up --build
         find . -name \*.whl
-    # TODO: remove
-    - name: DEBUG
-      run: pwd && find . -name \*.whl
     - name: Archive build artifacts
       uses: actions/upload-artifact@v2
       with:
diff --git a/dhib_env.py b/dhib_env.py
index e60f544f..f43e3579 100755
--- a/dhib_env.py
+++ b/dhib_env.py
@@ -13,6 +13,9 @@
 import pkginfo
 import requests
 
+IB_VERSION_DEFAULT="10.19.04"
+DH_VERSION_DEFAULT="0.33.3"
+
 ########################################################################################################################
 # Shell
 ########################################################################################################################
@@ -265,8 +268,8 @@ def cli():
 
 @click.command()
 @click.option('--python', default="python3", help='The path to the Python executable to use.')
-@click.option('--dh_version', default="0.33.3", help='The version of Deephaven.')
-@click.option('--ib_version', default="10.19.04", help='The version of ibapi.')
+@click.option('--dh_version', default=DH_VERSION_DEFAULT, help='The version of Deephaven.')
+@click.option('--ib_version', default=IB_VERSION_DEFAULT, help='The version of ibapi.')
 @click.option('--dh_ib_version', default=None, help='The version of deephaven-ib.')
 @click.option('--delete_venv', default=False, help='Whether to delete the virtual environment if it already exists.')
 def dev(python: str, dh_version: str, ib_version: str, dh_ib_version: Optional[str], delete_venv: bool):