Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy restricting usage of Istio annotations #1017

Open
mjnagel opened this issue Nov 18, 2024 · 2 comments
Open

Add policy restricting usage of Istio annotations #1017

mjnagel opened this issue Nov 18, 2024 · 2 comments
Labels
istio Issues related to istio components / resources security

Comments

@mjnagel
Copy link
Contributor

mjnagel commented Nov 18, 2024

Istio provides a number of resource annotations that can be used to adjust the sidecar's configuration. In particular there are a number of traffic.sidecar.istio.io/ annotations that can be used to modify how traffic is captured by the sidecar.

These annotations should be evaluated for security impact and where necessary we should block annotations with a policy. This policy should allow an exemption, likely named something like RestrictIstioAnnotations.

@mjnagel
Copy link
Contributor Author

mjnagel commented Nov 18, 2024

cc @bburky would be helpful to get your take on which annotations are particular important to block

@mjnagel mjnagel added security istio Issues related to istio components / resources labels Nov 18, 2024
@bburky
Copy link
Member

bburky commented Nov 18, 2024

There's so many it's hard to say. Conservatively I'd say all, and exempt things one by one if we know they're safe.

I know it's a bit of hassle to create more Exceptions, but I'd also suggest all the per-port mTLS exemptions should be flagged and allowed by Exception. Similarly permissive TLS (but that's a whole separate CR, not an annotation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
istio Issues related to istio components / resources security
Projects
None yet
Development

No branches or pull requests

2 participants