Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"device message" should not be a "forward" target, other forward issues #2436

Open
r10s opened this issue Dec 10, 2024 · 0 comments
Open

"device message" should not be a "forward" target, other forward issues #2436

r10s opened this issue Dec 10, 2024 · 0 comments
Labels

Comments

@r10s
Copy link
Member

r10s commented Dec 10, 2024

  • when forwarding messages, "device message" is shown in the list, probably also other read-only chats.
    we should make sure, GCL_FOR_FORWARDING is applied correctly when getting the chatlist

  • the forwarding list should also not start in "archive", even if the opened chat is in archive. this results in the same view always, and it is also more probable that one wants to forward to active chats

  • the "cancel" button atop of the chatlist should go back to the original chat. i think, only on first display, when no subsequent chats were opened. so for the usecase the user hits "forward" accidentally and immediately cancels.
    later on, when the user has navigated back and forth, maybe even forgot what they wanted to do, this may be confusion, there, the current behavior seems to be fitting better (in theory, we can think about leaving the underying viewcontroller stay (so have chatlist -> chat -> chatlist), however, that needs probably adds more cornercases, makes things as "create chat by forwarding" harder, and probably is larger refactoring, so i would only change the cancel-button)

  • when forwarding to "saved messages", we should also go to the original chat, see android. this is mitigated by the new "save" option, but still

@r10s r10s added the bug label Dec 10, 2024
@r10s r10s changed the title "device message" should not be a "forward" target "device message" should not be a "forward" target, other forward issues Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant