Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations should be adapter-implemented #378

Open
davewasmer opened this issue Aug 28, 2017 · 0 comments
Open

Migrations should be adapter-implemented #378

davewasmer opened this issue Aug 28, 2017 · 0 comments

Comments

@davewasmer
Copy link
Collaborator

Right now migrations are tied to knex. We should uncouple them so that you write migrations in whatever syntax your ORM supports, and Denali just handles the running/state management of migrations.

Also, might be nice to add a bit of autogeneration, i.e. generate migration add-users would look for a User model, load the file, and handoff to ORM which could try to construct an appropriate migration from the class definition.

The downside of adapter-specific migrations is that addons requiring migrations now can't supply their own prebuilt, out of the box. This could be potentially partially mitigated by the autogeneration described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant