Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unit tests from busted/luarocks to use 'mineunit'. #4

Open
dennisjenkins75 opened this issue Mar 29, 2021 · 0 comments
Open

Comments

@dennisjenkins75
Copy link
Owner

Per SX on Discord:

https://discord.com/channels/513329453741637637/809890578753650770/825866231835000892
https://discord.com/channels/513329453741637637/809890578753650770/826083288766218281

also still have not released "production" version so install command requires dev branch
luarocks install --server=https://luarocks.org/dev --local mineunit

qos has some clean tests with mineunit, might be good to look at:

Tried this and yes some changes would be needed.
tests -> spec is recommended (and maybe even required currently?) because mineunit uses only spec directory for tests and configurations by default.

Changes to test code are not that big, after renaming tests to spec:

After that luacheck however will complain about mineunit and sourcefile, no integration (yet) and so far I've simply added exclude_files = {"**/spec/**"} to .luacheckrc to not complain about test code at all.
changed busted . to mineunit --coverage --quiet && mineunit --report

dennisjenkins75 added a commit that referenced this issue Apr 3, 2021
…which wrappers those. This partially addresses issue #4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant