Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential resources cause constant diffs #9

Open
jtcarnes opened this issue Jul 4, 2022 · 0 comments
Open

Credential resources cause constant diffs #9

jtcarnes opened this issue Jul 4, 2022 · 0 comments

Comments

@jtcarnes
Copy link

jtcarnes commented Jul 4, 2022

Currently, all credential resources cause diffs between runs.

This is because they store the value from the read response, which always has the sensitive attributes (such as ssh_key_data) returning $encrypted$.

There are 3 solutions as I see it:

  1. AWX API needs to be changed to return a verifiable attribute, such as private key hash (unlikely)
  2. Store the private key from the create resource call and remove storing it from the read response. Benefit is the state knows the exact key and compare it to the input.
  3. Suppress the diff using DiffSupprrssFunc on the key data attribute in the schema that suppresses if the old value is "$encrypted$". Issue here is if the user does change key_data, it won't be picked up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant