New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove credentials #1

Open

mjvanmiddelaar opened this issue Jul 18, 2022 · 2 comments

mjvanmiddelaar commented Jul 18, 2022

Usually it is best not to disclose credentials in the source files like here
https://github.com/denzubechi/CoffeeShop-FullStack/blob/main/frontend/src/environments/environment.ts#L11

Author

mjvanmiddelaar commented Jul 18, 2022 •

edited

Loading

One way would be to use environment like .env.

I.e. https://medium.com/developer-secrets/storing-credentials-the-right-way-78074ae21727

Owner

denzubechi commented Jul 21, 2022

sure I removed them earlier, just had to keep them for the submission of the project.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment