forked from cds-snc/notification-api
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query API for Recipient Identifiers #239
Labels
VA Profile
VA Profile Integration
Comments
marisahoenig
added a commit
that referenced
this issue
Nov 2, 2020
philherbert
added a commit
that referenced
this issue
Nov 2, 2020
ffafara-tw
added a commit
that referenced
this issue
Nov 2, 2020
philherbert
added a commit
that referenced
this issue
Nov 6, 2020
Co-authored-by: saman.moshafi <[email protected]> Co-authored-by: Marisa Hoenig <[email protected]> Co-authored-by: Filip Fafara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Value Statement
As a VANotify consumer
I want to know what VA identifiers are associated with a notification
So that I know how the notification was created
(is this also so we know the notification's status of querying VA Profile or another system?) - not really - if we want that behaviour, that should probably be expressed through the
status
fieldAcceptance Criteria
AC1. Recipient identifiers? Comin' right up!
GIVEN I have made a request to send a notification
AND GIVEN I specified a
recipient_identifier
WHEN I make a request to query the status and details of that notification
THEN the response includes a
recipient_identifiers
list, containing all identifiers associated with that notificatione.g.
AC2. Recipient identifiers? We're fresh out, I'm afraid
GIVEN I have made a request to send a notification
AND GIVEN I did not specify a
recipient_identifier
WHEN I make a request to query the status and details of that notification
THEN the response includes an empty
recipient_identifiers
listChecklist
GET v2/notifications/<id>
endpoint to returnrecipient_identifiers
in response:models.Notification.serialize()
to includerecipient_identifiers
if the notification has associated identifiers - seescheduled_for
for a similar exampleAdd to user flows- not doing this, because we currently don't have a user flow test for the recipient identifiers path - we can create one once we have more of a complete flow with VA Profile and MPIAssumptions
Additional Info/Resources
Out of Scope
Open Questions
Do we want to return the- yes, we want to return the value, and it's not PIIvalue
for eachrecipient_identifier
? Would this be PII?Should we return all identifiers associated with this notification?- yes, so we can get a full picture of the data used to create and send a notificationThe text was updated successfully, but these errors were encountered: