Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Migration VAIconWithText to Design System Icon #9733

Closed
Sparowhawk opened this issue Sep 27, 2024 · 10 comments
Closed

Icon Migration VAIconWithText to Design System Icon #9733

Sparowhawk opened this issue Sep 27, 2024 · 10 comments
Assignees
Labels
blocked-QA Ticket is blocked by QA front-end Ticket requires front-end work global Issues for the global team Health Tickets are tied to the Health Product Team Pms QA 2 QA work sized as a 2

Comments

@Sparowhawk
Copy link
Contributor

No description provided.

@Sparowhawk Sparowhawk added front-end Ticket requires front-end work Health Tickets are tied to the Health Product Team Pms labels Sep 27, 2024
@TKDickson TKDickson added the global Issues for the global team label Oct 1, 2024
@TKDickson TKDickson assigned TKDickson and unassigned rbontrager Oct 1, 2024
@TKDickson
Copy link
Contributor

Passing Android detox test (the URL links is failing in develop; not just this branch); re-running several for iOS right now.

@TKDickson
Copy link
Contributor

Relevant slack thread (many screenshots, some conversation) whenever testing on this ticket occurs

@TKDickson TKDickson added the blocked-QA Ticket is blocked by QA label Oct 3, 2024
@TKDickson
Copy link
Contributor

Over my ticket capacity; not working on this.

@TKDickson TKDickson assigned rbontrager and unassigned TKDickson Oct 7, 2024
@TKDickson
Copy link
Contributor

Switching to RB - looking at my day today/tomorrow, I'm not getting to this in time this sprint. Leaving the blocked label on, @rbontrager FYI

@rbontrager rbontrager added the QA 2 QA work sized as a 2 label Oct 7, 2024
@rbontrager
Copy link
Contributor

This is currently blocked by a potential issue with the design system home icon. More info can be found here.

@rbontrager rbontrager added the Blocked - Component Library blocked due to an issue with the component library from the design system team label Oct 8, 2024
@dumathane
Copy link
Contributor

It seems like from @rbontrager 's thread this ticket now needs app design system to decide if we want the home to be smaller or to custom resize to match? Does that sound accurate rachael? If so should we tag in @kidlaurenpeace ?

@rbontrager
Copy link
Contributor

Yes that is accurate. @wavelaurenrussell You can read the thread linked above but basically I noticed that the home icon looked smaller than the rest of the icons in the nav tab bar. After a discussion with the design team we need to make the decision if we want to resize the icon and you are probably best to make that decision. I've attached a screenshot of what the current home icon looks like in relationship to the rest of the icons that I showed in the thread. I can also find you the original build/give you more screenshots if that would help as well (just let me know).

Screenshot_20241008-095011.png

@wavelaurenrussell
Copy link

Yes, confirmed. We should match the Home / Selected state as close to the others as possible.

@Sparowhawk
Copy link
Contributor Author

@Sparowhawk Sparowhawk removed the Blocked - Component Library blocked due to an issue with the component library from the design system team label Oct 22, 2024
@rbontrager
Copy link
Contributor

Lauren confirmed through VQA that the updated home icon sizing is good here. Verified that the prescriptions > help icon, edit draft > folder/trash icon, profile icon, and navigation tab bar icons (Home, Benefits, Health, Payments) look correct and match what is in the va-mobile-design-system library. Ran a basic a11y check (text resizing, keyboard, dark mode, landscape, voiceOver) and verified that nothing looked/sounded wrong. Approved by QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-QA Ticket is blocked by QA front-end Ticket requires front-end work global Issues for the global team Health Tickets are tied to the Health Product Team Pms QA 2 QA work sized as a 2
Projects
None yet
Development

No branches or pull requests

5 participants