-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon Migration VAIconWithText to Design System Icon #9733
Comments
Relevant slack thread (many screenshots, some conversation) whenever testing on this ticket occurs |
Over my ticket capacity; not working on this. |
Switching to RB - looking at my day today/tomorrow, I'm not getting to this in time this sprint. Leaving the blocked label on, @rbontrager FYI |
This is currently blocked by a potential issue with the design system home icon. More info can be found here. |
It seems like from @rbontrager 's thread this ticket now needs app design system to decide if we want the home to be smaller or to custom resize to match? Does that sound accurate rachael? If so should we tag in @kidlaurenpeace ? |
Yes that is accurate. @wavelaurenrussell You can read the thread linked above but basically I noticed that the home icon looked smaller than the rest of the icons in the nav tab bar. After a discussion with the design team we need to make the decision if we want to resize the icon and you are probably best to make that decision. I've attached a screenshot of what the current home icon looks like in relationship to the rest of the icons that I showed in the thread. I can also find you the original build/give you more screenshots if that would help as well (just let me know). |
Yes, confirmed. We should match the Home / Selected state as close to the others as possible. |
Match the sizing as close as possible |
Lauren confirmed through VQA that the updated home icon sizing is good here. Verified that the prescriptions > help icon, edit draft > folder/trash icon, profile icon, and navigation tab bar icons (Home, Benefits, Health, Payments) look correct and match what is in the va-mobile-design-system library. Ran a basic a11y check (text resizing, keyboard, dark mode, landscape, voiceOver) and verified that nothing looked/sounded wrong. Approved by QA. |
No description provided.
The text was updated successfully, but these errors were encountered: