Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback 2779 and confirm if RQ is less reliant on AbortControllers #9768

Closed
2 tasks
dumathane opened this issue Oct 3, 2024 · 1 comment
Closed
2 tasks
Assignees
Labels
front-end Ticket requires front-end work global Issues for the global team QA 1 QA work sized as a 1

Comments

@dumathane
Copy link
Contributor

dumathane commented Oct 3, 2024

Proposed Change

2779 was developed to ensure our api responses weren't stepping on top of each other in our old redux environment. I'd like to confirm whether or not this is still necessary in a React Query environment. This takeaway will drive how we have to use AbortController app-wide.

Why Should We Prioritize?

This takeaway will drive how we have to use AbortController app-wide.

Coding Time Estimation

2

Testing Considerations

Follow same initial bug testing steps that existed previously on 2779:
'Tap on claim A
Realize (while it's still loading) that I meant to tap claim B
Tap back to get to the list, then tap claim B
Wait for claim B to load -- actually shows the details of claim A'

AC's:
[ ] - A branch build is created with 2779 changes disabled
[ ] - QA tests branch and is able/unable to reproduce original problem
[ ] - If unable, AbortController removal from claims/appeals can be merged, and our use of AbortControllers can be limited to edge case screens like Address Validation and Batch Refill Requests.
[ ] - If still reproducible, we'll need to close the pull request as is and use AbortControllers basically everywhere.

Checklist

  • Add the relevant team label (Health, global, design system, API, Qa and Release etc.)
  • Attach to ticket to the relevant Team Tech Debt Epic epic (old frontend engineering epic is no longer in use as each team is managing their code's technical debt and code upkeep work)
@dumathane dumathane added front-end Ticket requires front-end work global Issues for the global team labels Oct 3, 2024
@cadibemma cadibemma self-assigned this Oct 15, 2024
@rbontrager rbontrager added the QA 1 QA work sized as a 1 label Oct 28, 2024
@rbontrager
Copy link
Contributor

Verified that if you tap on claim A, wait a couple of seconds and back out while it is still loading and tap on claim b that claim b's details will display correctly. Verified in charles that the claim is loading properly as well. Approved by QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Ticket requires front-end work global Issues for the global team QA 1 QA work sized as a 1
Projects
None yet
Development

No branches or pull requests

3 participants