Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive v1/v3 va-table loses headers on smaller screens #3327

Closed
2 of 6 tasks
randimays opened this issue Oct 2, 2024 · 2 comments · Fixed by department-of-veterans-affairs/component-library#1364
Closed
2 of 6 tasks
Assignees
Labels
bug Something isn't working platform-design-system-team va-table DS Table component

Comments

@randimays
Copy link

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

<va-table>, both v1 and v3, lose the table headers on smaller screens (400px and 768px in the below screenshots). This problem exists on v1 tables in prod, and it remains in the v3 tables we are attempting to implement locally in a dev branch.

In the below screenshots (from production), the "Depart" and "Arrive" headers are missing and it's not clear what the times indicate.

This page is https://www.va.gov/pittsburgh-health-care/shuttle-schedule/.

400px

768px

1000px

What I expected to happen

I expected that the headers would stick throughout breakpoints as they have important contextual information.

DST initially suggested we set the stacked property in the table to false, but:

  1. this doesn't make the headers stick throughout breakpoints
  2. in some cases, the table will need to be horizontally scrolled which is not ideal
  3. content is editor-controlled/dynamic (coming from Drupal) and if we set the stacked property we're setting it for every table without knowing whether it's the right solution

Slack thread with DST: https://dsva.slack.com/archives/C01DBGX4P45/p1727883538474889

Reproducing

This also happens in the Storybook for DS, but the data that is shown in the example bordered table is clear enough (perhaps) that it doesn't seem to be a big deal?

https://design.va.gov/storybook/?path=/docs/uswds-va-table--docs

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

👉🏻 This bug is not blocking work, but it is currently affecting data in production (and thus cognition / clarity of the data). I would say it is somewhat urgent but since it's an existing prod issue I'm not sure.

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other
@caw310
Copy link
Contributor

caw310 commented Oct 8, 2024

@micahchiang
Copy link
Contributor

Looks like headers get removed in a media query here. I can't remember what the decision was for this, but I checked uswds table and it doesn't seem to strip the headers on narrow widths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-design-system-team va-table DS Table component
Projects
None yet
4 participants