Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidenav on Benefit Detail Pages have loading issues #3757

Open
2 of 6 tasks
chriskim2311 opened this issue Jan 28, 2025 · 1 comment
Open
2 of 6 tasks

Sidenav on Benefit Detail Pages have loading issues #3757

chriskim2311 opened this issue Jan 28, 2025 · 1 comment
Labels
bug Something isn't working platform-design-system-team

Comments

@chriskim2311
Copy link

chriskim2311 commented Jan 28, 2025

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

On page load for benefit detail pages such as https://www.va.gov/health-care/about-va-health-benefits/ There is a visible change and motion in the accordion items being open or closed. This happens for all links in the sidenav if you navigate to a nested item.

What I expected to happen

There should be seamless loading of the accordion. No motion or jumpiness of the accordion and its items trying to figure out which item needs to be opened.

Reproducing

  • CSS Library version:
  • Device: Macbook
  • Browser: Chrome

Steps to reproduce:

  1. https://www.va.gov/health-care/about-va-health-benefits/
  2. Notice the left sidenav on page load will show motion and open and closing

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

I worked on a change for fixing the left sidenav not opening on the proper accordion on page load. PR here: department-of-veterans-affairs/vets-website#34243.

Original DST slack thread: https://dsva.slack.com/archives/C01DBGX4P45/p1734629286173609

There is something going on with this legacy formation javascript that is overriding the accordion aria-hidden attributes.

Issue first reported from CAIA

@chriskim2311
Copy link
Author

@mnorthuis FYSA just opened this ticket for better tracking of the progress on the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-design-system-team
Projects
None yet
Development

No branches or pull requests

1 participant