diff --git a/examples/management-cli/pom.xml b/examples/management-cli/pom.xml index d4579d46..032bbf97 100644 --- a/examples/management-cli/pom.xml +++ b/examples/management-cli/pom.xml @@ -19,7 +19,7 @@ com.descope java-sdk - 1.0.27 + 1.0.30 info.picocli diff --git a/pom.xml b/pom.xml index 05b5a28b..7056542a 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ com.descope java-sdk 4.0.0 - 1.0.29 + 1.0.30 ${project.groupId}:${project.artifactId} Java library used to integrate with Descope. https://github.com/descope/descope-java diff --git a/src/main/java/com/descope/model/sso/SSOSAMLSettings.java b/src/main/java/com/descope/model/sso/SSOSAMLSettings.java index 1864a0e8..cac5959b 100644 --- a/src/main/java/com/descope/model/sso/SSOSAMLSettings.java +++ b/src/main/java/com/descope/model/sso/SSOSAMLSettings.java @@ -19,4 +19,8 @@ public class SSOSAMLSettings { private String spEncryptionKey; private String spSignKey; private String subjectNameIdFormat; + // NOTICE - the following fields should be overridden only in case of SSO migration, + // otherwise, do not modify these fields + private String spACSUrl; + private String spEntityId; } diff --git a/src/main/java/com/descope/model/sso/SSOSAMLSettingsByMetadata.java b/src/main/java/com/descope/model/sso/SSOSAMLSettingsByMetadata.java index 76e42e58..b4f4cab7 100644 --- a/src/main/java/com/descope/model/sso/SSOSAMLSettingsByMetadata.java +++ b/src/main/java/com/descope/model/sso/SSOSAMLSettingsByMetadata.java @@ -17,4 +17,8 @@ public class SSOSAMLSettingsByMetadata { private String spEncryptionKey; private String spSignKey; private String subjectNameIdFormat; + // NOTICE - the following fields should be overridden only in case of SSO migration, + // otherwise, do not modify these fields + private String spACSUrl; + private String spEntityId; } diff --git a/src/test/java/com/descope/sdk/mgmt/impl/SsoServiceImplTest.java b/src/test/java/com/descope/sdk/mgmt/impl/SsoServiceImplTest.java index 95cd6e81..9efe4fc7 100644 --- a/src/test/java/com/descope/sdk/mgmt/impl/SsoServiceImplTest.java +++ b/src/test/java/com/descope/sdk/mgmt/impl/SsoServiceImplTest.java @@ -291,6 +291,8 @@ void testFunctionalFullCycleSAML() { .spEncryptionKey(TestUtils.MOCK_PRIVATE_KEY_STRING) .spSignKey(TestUtils.MOCK_PRIVATE_KEY_STRING) .subjectNameIdFormat(unspecifiedFormat) + .spACSUrl("https://spacsurl.com") + .spEntityId("spEntityId") .build(), "https://" + name + ".com", null); SSOTenantSettingsResponse resp = ssoService.loadSettings(tenantId); assertEquals(tenantId, resp.getTenant().getId()); @@ -307,6 +309,8 @@ void testFunctionalFullCycleSAML() { assertThat(signCert).isNotBlank(); assertThat(newSignCert).isNotEqualTo(signCert); assertThat(unspecifiedFormat).isEqualTo(resp.getSaml().getSubjectNameIdFormat()); + assertEquals("https://spacsurl.com", resp.getSaml().getSpACSUrl()); + assertEquals("spEntityId", resp.getSaml().getSpEntityId()); ssoService.deleteSettings(tenantId); tenantService.delete(tenantId); }