Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

desisim/spec_qa/s2n: don't read files multiple times #444

Open
sbailey opened this issue Oct 26, 2018 · 0 comments
Open

desisim/spec_qa/s2n: don't read files multiple times #444

sbailey opened this issue Oct 26, 2018 · 0 comments
Assignees
@profxj

Comments

@sbailey
Copy link
Contributor

sbailey commented Oct 26, 2018

While debugging a separate issue, I found that desi_qa_s2n is quite slow because it keeps reading in the same truth and cframe files over and over again via load_s2n_values(objtype, nights, channel).

Refactor to read in the data only once, and then filter as needed for various objtype and channels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@profxj profxj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbailey @profxj