From 5161f40d965b6cb7e62bfdfa3a76312978d6c446 Mon Sep 17 00:00:00 2001 From: stiebels <15859432+stiebels@users.noreply.github.com> Date: Fri, 16 Feb 2024 13:20:42 +0100 Subject: [PATCH 1/2] Fixed train.py call with correct argument passing --- examples/object-detection/pipelines/training-pipeline.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/object-detection/pipelines/training-pipeline.json b/examples/object-detection/pipelines/training-pipeline.json index a1147ac..b53b1e1 100644 --- a/examples/object-detection/pipelines/training-pipeline.json +++ b/examples/object-detection/pipelines/training-pipeline.json @@ -17,7 +17,7 @@ "/bin/sh" ], "stdin": [ - "python train.py --git-url https://git@github.com:/determined-ai/pdk.git --git-ref main --sub-dir examples/object-detection/experiment --config const.yaml --repo object-detection-data --model object-detection --project pdk-object-detection --incremental false" + "python train.py --git-url https://git@github.com:/determined-ai/pdk.git --git-ref main --sub-dir examples/object-detection/experiment --config const.yaml --repo object-detection-data --model object-detection --project pdk-object-detection --no-incremental" ], "image": "pachyderm/pdk:train-v0.0.5", "secrets": [ @@ -44,4 +44,4 @@ ] }, "autoscaling": true -} +} \ No newline at end of file From 245a725028704f0eb708fe32a4887ea3814a988c Mon Sep 17 00:00:00 2001 From: stiebels <15859432+stiebels@users.noreply.github.com> Date: Fri, 16 Feb 2024 13:31:45 +0100 Subject: [PATCH 2/2] Apply fix to on-prem pipeline config as well --- .../pipelines/_on_prem_training-pipeline.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/object-detection/pipelines/_on_prem_training-pipeline.json b/examples/object-detection/pipelines/_on_prem_training-pipeline.json index 0fc44a4..a5f5a6a 100644 --- a/examples/object-detection/pipelines/_on_prem_training-pipeline.json +++ b/examples/object-detection/pipelines/_on_prem_training-pipeline.json @@ -17,7 +17,7 @@ "/bin/sh" ], "stdin": [ - "python train.py --git-url https://git@github.com:/determined-ai/pdk.git --git-ref main --sub-dir examples/object-detection/experiment --config const.yaml --repo object-detection-data --model object-detection --project pdk-object-detection --incremental false" + "python train.py --git-url https://git@github.com:/determined-ai/pdk.git --git-ref main --sub-dir examples/object-detection/experiment --config const.yaml --repo object-detection-data --model object-detection --project pdk-object-detection --no-incremental" ], "image": "pachyderm/pdk:train-v0.0.5", "secrets": [ @@ -45,4 +45,4 @@ }, "autoscaling": true, "pod_patch": "[{\"op\": \"add\",\"path\": \"/volumes/-\",\"value\": {\"name\": \"det-checkpoints\",\"hostpath\": {\"path\": \"/mnt/efs/shared_fs/determined\",\"type\": \"Directory\"}}}, {\"op\": \"add\",\"path\": \"/containers/0/volumeMounts/-\",\"value\": {\"mountPath\": \"/determined_shared_fs\",\"name\": \"det-checkpoints\"}}]" -} +} \ No newline at end of file