Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I hope to add one more parameter to set video size, now in multi-picture mode. Size is fixed proportion. #62

Open
cs571393 opened this issue Nov 19, 2019 · 8 comments
Labels
Proposed enhancement A feature proposed and implemented by a contributor

Comments

@cs571393
Copy link

No description provided.

@tgeorgieva
Copy link
Collaborator

@cs571393 Can you label your issue appropriately or add proper description if it's a bug you need help with?

@cs571393
Copy link
Author

@tgeorgieva
Now in VideoGeneratorType. Multiple types, the setup method will default to 800 * 800 the image format, associated with videoImageWidthForMultipleVideoGeneration, now only a fixed ratio of 1:1.
I want to add a parameter that sets the size of video. So let's say 1920 times 1080. Set it like this.

@tgeorgieva
Copy link
Collaborator

@cs571393 OK, feel free to fork the project and implement your changes. I don't know why you aded an issue, but I'll mark it as improvement. If you feel like creating a pull request after you've finished and tested the feature, I'll look it over and consider adopting it into the project.

@tgeorgieva tgeorgieva added the Proposed enhancement A feature proposed and implemented by a contributor label Nov 19, 2019
@cs571393
Copy link
Author

@tgeorgieva
If yes, can I set the project to 9.0? Now I can only import files into the project, but I cannot import them through cocoapod. Because my project is the lowest version that supports iOS9.0

@tgeorgieva
Copy link
Collaborator

@cs571393 You can do as you wish in your own project but I won't accept a merge request with a lower version. I'm not sure if some of the methods I use are even supported by lower versions of iOS anyway.
Again, though, you can try to lower it in your own forked project and see if it works for you.

@cs571393
Copy link
Author

@tgeorgieva Can you add a cancel method?

@tgeorgieva
Copy link
Collaborator

@cs571393 What cancel method? Is this a bug you have? Or an improvement you need? I really don't understand why this issue was opened.

@cs571393
Copy link
Author

@tgeorgieva I happen to have a function in my app that composes video, and a function that cancels compositing, so I hope to have a function that can be cancelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposed enhancement A feature proposed and implemented by a contributor
Projects
None yet
Development

No branches or pull requests

2 participants