Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for from-timestamp message consumption #121

Closed
pierre-degrandmaison opened this issue Mar 4, 2022 · 3 comments
Closed

Support for from-timestamp message consumption #121

pierre-degrandmaison opened this issue Mar 4, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pierre-degrandmaison
Copy link

Converting timestamp to topic/partition offset is not easy without coding.... a nice new feature would be to be able to consume messages by providing from-timestamp, and let the kafkactl code compute the corresponding start offset value.

@d-rk
Copy link
Collaborator

d-rk commented Mar 4, 2022

Hey @pierre-degrandmaison
I already thought about this and implementing it would be not that complicated.

In this method one could determine the start offset with:

oldestOffset, err = (*client).GetOffset(topic, partition, fromTS)

So if you are willing to work on it, a PR is always welcome 😃

Cheers

@d-rk d-rk added enhancement New feature or request good first issue Good for newcomers labels Mar 4, 2022
@nanic nanic mentioned this issue May 11, 2022
2 tasks
@nanic
Copy link
Contributor

nanic commented May 11, 2022

Hi @d-rk, Please let me know if you think the changes are enough and if i am missing anything. I did notice the timeout issue referred in #67 .

@pierre-degrandmaison
Copy link
Author

Works great! very useful, thank you

@d-rk d-rk closed this as completed Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants