Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweethandle should be optional #62

Open
jayv opened this issue Jul 1, 2013 · 2 comments
Open

tweethandle should be optional #62

jayv opened this issue Jul 1, 2013 · 2 comments
Assignees

Comments

@jayv
Copy link
Contributor

jayv commented Jul 1, 2013

Today we had a speaker without tweethandle he had to use a fake handle to submit somthing, this field is optional in the DB, the UI should allow blanks.

@ghost ghost assigned jankeesvanandel Jul 1, 2013
@LostInBrittany
Copy link
Contributor

In UserService.js the isProfileComplete function validates a profile, and for that service Twitter handle is optional.

In the view, speaker_details.html , tweethandle is not marked as required (no ng-required=true as the required attributes), so it shouldn't be required.

Testing to try to see where the problem is.

@LostInBrittany
Copy link
Contributor

I fail to see where tweethandle is needed. I've just tried to create a new user, and it doesn't ask me for a tweet handle :
user_creation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants