Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ic_ledger_types version conflicts #28

Closed
peterpeterparker opened this issue Dec 2, 2024 · 0 comments · Fixed by #32
Closed

ic_ledger_types version conflicts #28

peterpeterparker opened this issue Dec 2, 2024 · 0 comments · Fixed by #32

Comments

@peterpeterparker
Copy link
Member

Motivation

If a consumer is using a different version of the IC ledger types, such as the latest v0.14.0, they cannot declare an ObtainCyclesOptions because the required from_subaccount must match the type defined by this crate's dependency, which is currently v0.12.0.

Solution

Always update IC dependencies within the crate to align with the IC's versioning pace, assuming that developers also keep up with these updates. Alternatively, re-export the type to avoid conflicts.

Workaround

Consumers can pin and import multiple times the ledger types in their projects.

ic-ledger-types.workspace = "0.14.0"
ic-ledger-types-for-canfund = { package = "ic-ledger-types", version = "0.12.0" }
@peterpeterparker peterpeterparker linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant