From 08e38abbd57a5cdbe5c15e52f7bc0d06949c2265 Mon Sep 17 00:00:00 2001
From: jasonz-dfinity <133917836+jasonz-dfinity@users.noreply.github.com>
Date: Tue, 4 Feb 2025 16:11:30 -0800
Subject: [PATCH] Stop sending exchange rate proposal as part of NNS setup
 (#136)

---
 extensions/nns/extension.json     |  2 +-
 extensions/nns/src/install_nns.rs | 25 -------------------------
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/extensions/nns/extension.json b/extensions/nns/extension.json
index d5519650..7cec0790 100644
--- a/extensions/nns/extension.json
+++ b/extensions/nns/extension.json
@@ -12,7 +12,7 @@
     "deployment"
   ],
   "dependencies": {
-    "dfx": ">=0.17.0"
+    "dfx": ">=0.24.1"
   },
   "subcommands": {
     "import": {
diff --git a/extensions/nns/src/install_nns.rs b/extensions/nns/src/install_nns.rs
index b79ee108..a916dc54 100644
--- a/extensions/nns/src/install_nns.rs
+++ b/extensions/nns/src/install_nns.rs
@@ -255,7 +255,6 @@ pub async fn install_nns(
     }
     // ... and configure the backend NNS canisters:
     eprintln!("Configuring the NNS...");
-    set_xdr_rate(1234567, &nns_url, dfx_cache_path)?;
     set_cmc_authorized_subnets(&nns_url, &default_subnet_id.to_string(), dfx_cache_path)?;
 
     print_nns_details(provider_url)?;
@@ -580,30 +579,6 @@ pub async fn ic_nns_init(opts: &IcNnsInitOpts, dfx_cache_path: &Path) -> anyhow:
     call_extension_bundled_binary("ic-nns-init", &args, dfx_cache_path)
 }
 
-/// Sets the exchange rate between ICP and cycles.
-///
-/// # Implementation
-/// This is done by proposal.  Just after starting a test server, ic-admin
-/// proposals with a test user pass immediately, as the small test neuron is
-/// the only neuron and has absolute majority.
-#[context("Failed to set an initial exchange rate between ICP and cycles. It may not be possible to create canisters or purchase cycles.")]
-pub fn set_xdr_rate(rate: u64, nns_url: &Url, dfx_cache_path: &Path) -> anyhow::Result<()> {
-    let summary = format!("Set the cycle exchange rate to {}.", rate.clone());
-    let xdr_permyriad_per_icp = rate.to_string();
-    let args = vec![
-        "--nns-url",
-        nns_url.as_str(),
-        "propose-xdr-icp-conversion-rate",
-        "--test-neuron-proposer",
-        "--summary",
-        &summary,
-        "--xdr-permyriad-per-icp",
-        &xdr_permyriad_per_icp,
-    ];
-    call_extension_bundled_binary("ic-admin", args, dfx_cache_path)
-        .map_err(|e| anyhow!("Call to propose to set xdr rate failed: {e}"))
-}
-
 /// Sets the subnets the CMC is authorized to create canisters in.
 #[context("Failed to authorize a subnet for use by the cycles management canister. The CMC may not be able to create canisters.")]
 pub fn set_cmc_authorized_subnets(