Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mylineups.csv DraftKings NFL needs extra commas in header #42

Open
abm515 opened this issue Nov 18, 2022 · 1 comment
Open

mylineups.csv DraftKings NFL needs extra commas in header #42

abm515 opened this issue Nov 18, 2022 · 1 comment

Comments

@abm515
Copy link

abm515 commented Nov 18, 2022

Hi! I've never contributed to a GitHub project. I think I found a glitch in DraftKings NFL where the mylineups.csv is writing
QB,RB,RB,WR,WR,WR,TE,FLEX,DST
where it needs to be
QB,RB,RB,WR,WR,WR,TE,FLEX,DST,,
in order to avoid an error. I imagine they changed the required format after you published.

Seems to me that we need to change this line in https://github.com/dfs-with-r/coach/blob/master/R/write.r
pos_levels <- c("QB", "RB", "WR", "TE", "FLEX", "DST")
to
pos_levels <- c("QB", "RB", "WR", "TE", "FLEX", "DST","","")
but I'm not 100% sure. I'd be happy to change the code and contribute, I've just never changed anything in GitHub so I may need a bit of hand-holding, and also would like to hear your opinion on if this would fix the issue.

Thanks!
a

@zamorarr
Copy link
Collaborator

Hi @abm515 thanks for catching that! Yup I am happy to walk you through submitting this change. Do you happen to have an example file that DraftKings would accept? You can just attach it to a comment here.

As for submitting a change, can you try going to https://github.com/dfs-with-r/coach/blob/master/R/write.r and clicking the Edit icon (looks like a pencil)? You should be able to make a change and submit a Pull Request. If Github does not allow you to do that, you might have to Fork the repository first (icon looks like the Sharing icon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants