Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throws JSON error for empty score file #19

Open
dgw opened this issue Aug 23, 2015 · 0 comments
Open

Throws JSON error for empty score file #19

dgw opened this issue Aug 23, 2015 · 0 comments
Assignees
@dgw
Labels
bug presentation

Comments

@dgw
Copy link
Owner

dgw commented Aug 23, 2015

It's not a major issue. As is evident from the logs, the scores are saved—but it shouldn't spit out an error that doesn't matter.

<@WZ1> .unotop
<@Masa-chan> Error loading UNO scores: No JSON object could be decoded
<@Masa-chan> No scores yet
<@WZ1> kek

<@WZ1> .play b 8
<@Masa-chan> We have a winner: WZ1!!! This game took 00:11:46
<@Masa-chan> WZ1 gains 21 points!
<@Masa-chan> Error loading UNO scores: No JSON object could be decoded
<@WZ1> ffs

<@dgw> .unotop
<@Masa-chan> #1 WZ1 (21 points in 1 game (1 won), 0:11:46 wasted)
@dgw dgw self-assigned this Aug 24, 2015
dgw added a commit that referenced this issue Sep 9, 2015
@dgw
Try to handle empty/nonexistent scorefile better
ef1f327 
Incomplete and lacks testing, but should be at least partial progress
toward fixing #19. Will complete refactoring if fix works in testing
(probably to be done by @WeiZs1).
dgw added a commit that referenced this issue Oct 19, 2015
@dgw
Complete refactor of get_scores() / load_scores()
c8f7c0d 
Eliminates TODO left in ef1f327. Reference #19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgw dgw

Labels
bug presentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgw