Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect command still completes tutorial step #1

Open
kkiningh opened this issue Aug 16, 2013 · 3 comments
Open

Incorrect command still completes tutorial step #1

kkiningh opened this issue Aug 16, 2013 · 3 comments

Comments

@kkiningh
Copy link

I was able to complete the first step of the tutorial by typing "dockerr version" even though the command output in the terminal was "dockerr: command not found."

Looking through the source code it looks like this is related to line 519 of steps.coffee
if input.containsAllOfTheseParts(_q.command_expected)
since containsAllOfTheseParts does a partial match on its inputs instead of an exact match.

@dhrp
Copy link
Owner

dhrp commented Aug 16, 2013

Thanks for your feedback! Indeed I do partial matching, basically to prevent silly things to make it fail. I'll think about improving the strict parsing for some of the command components.

@gabceb
Copy link

gabceb commented Sep 20, 2013

What about just switching to use containsAllOfThese?

The only silly thing that could be special cased is the use of ' vs "

EDIT: Doing this may also be problematic when using the short docker ID on the tutorial. Hmmmm....

@dhrp
Copy link
Owner

dhrp commented Sep 20, 2013

EDIT: Doing this may also be problematic when using the short docker ID on the tutorial. Hmmmm....

Yup. But since people seem to care I'll see if I can improve it. Will need to make changes anyway with the Docker CLI changes coming up.

dhrp pushed a commit that referenced this issue Mar 2, 2014
added link to michael crosby's post
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants