Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grader outdated again? #99

Open
desdoo opened this issue Dec 7, 2021 · 4 comments
Open

Grader outdated again? #99

desdoo opened this issue Dec 7, 2021 · 4 comments

Comments

@desdoo
Copy link

desdoo commented Dec 7, 2021

Hey @dibgerge , I just stumbled across this repo over Reddit and was super happy to do the ML course in Python. However, I think the grader is not working as it wasn't taking my first warmUpExercise(), eventhough the outputted matrix seems to be correct.

Bildschirmfoto 2021-12-07 um 21 37 28

n

Am I doing something wrong or is the repo indeed outdated?

@solutum
Copy link

solutum commented Dec 12, 2021

Same problem

@aesir321
Copy link

aesir321 commented Dec 17, 2021

There is a problem in the submission.py file, where the index is assumed to start at 1, but actually starts at zero. This results in the exercise part names displaying in the wrong order. The score and feedback is correct but the part name is incorrect.

You can fix this in two ways either:

line set the start value of the enumerate function to be = 1 (line 44, change is on line 44)

for index, part in enumerate(parts, start=1)

or change the part where the index is assumed to be ones based (change is on line 49)
print('%43s | %9s | %-s' % (self.part_names[int(index)], score, part_feedback))

@19007361
Copy link

Confirmed, everything needs to be shifted upwards by one. Thanks for the fix, @aesir321

@dibgerge
Copy link
Owner

Thanks. This change is merged now.

@dibgerge dibgerge pinned this issue Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants