-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pre-decoded rules #88
Comments
@beeme1mr 😅 Heya, just a small heads up, because y'all are using
Relevant Issue w/ an Experiment: handlebars-lang/handlebars.js#1934 (comment) However, in v2 of JSON Logic Engine (and y'all should be able to seamlessly upgrade to the latest, which is like So as long as the object isn't being changed out / cloned, it can optimize it. If y'all want to get the full performance benefits, y'all will need to switch to precompiling the logic with Also: I need to update that darned website 😅; I've been on a performance kick and trying to trim the codebase a bit. |
Hey @diegoholiveira, thanks for the great library. We're using it as part of our flag evaluation engine in flagd. I was wondering if we could add support for pre-decoding the rules so that it doesn't need to happen on every call to
Apply
. JSON Logic engine, a JavaScript version of Json Logic, supports this, and the performance benefits are impressive. This approach would work well for use because changes to feature flag configuration happen relatively infrequently, while evaluations can happen extremely frequently.If you're open to the idea, someone from the flagd community or I can work on a PR. Thanks!
The text was updated successfully, but these errors were encountered: