TextEditorPlugin: theme in config might be empty

If the theme is "", code can be simplified (do nothing). Before it tried opening a null file and fail. This would add a warning on the console.
diegoiast · Feb 1, 2025 · 8a23989 · 8a23989
1 parent 8562227
commit 8a23989
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/plugins/texteditor/texteditor_plg.cpp b/src/plugins/texteditor/texteditor_plg.cpp
@@ -280,13 +280,14 @@ void TextEditorPlugin::loadConfig(QSettings &settings) {
 
     auto themeFileName = getConfig().getTheme();
     delete this->theme;
-    this->theme = new Qutepart::Theme();
-    if (!this->theme->loadTheme(themeFileName)) {
-        qDebug() << "Failed loading thene " << themeFileName;
-        delete this->theme;
-        this->theme = nullptr;
+    if (!themeFileName.isEmpty()) {
+        this->theme = new Qutepart::Theme();
+        if (!this->theme->loadTheme(themeFileName)) {
+            qDebug() << "Failed loading theme " << themeFileName;
+            delete this->theme;
+            this->theme = nullptr;
+        }
     }
-
     auto history = getConfig().getSeachHistory();
     historyModel->setHistory(history);
 }