From b3cc3f528f71b0877a406c65cadfbecda7aca756 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jose=20Antonio=20Caba=C3=B1eros?= Date: Fri, 30 Aug 2024 10:29:37 +0200 Subject: [PATCH] fix(layout): avoid shared CSS classes between layouts with scoped (#1605) --- .../src/components/animations/cross-fade.vue | 2 +- .../animations/staggered-fade-and-slide.vue | 7 +- .../src/components/auto-progress-bar.vue | 2 +- .../fixed-header-and-asides-layout.vue | 188 ++++---- .../layouts/multi-column-max-width-layout.vue | 427 +++++++++--------- .../layouts/single-column-layout.vue | 112 ++--- .../utilities/dev-mode.css | 12 + .../utilities/dev-mode.scss | 14 - packages/x-components/src/views/ResultApp.vue | 40 +- .../accessibility/wai-base-event-button.vue | 2 +- packages/x-components/src/views/home/Home.vue | 4 +- .../x-components/src/views/home/result.vue | 6 +- .../components/search-input-placeholder.vue | 10 +- 13 files changed, 398 insertions(+), 428 deletions(-) create mode 100644 packages/x-components/src/design-system-deprecated/utilities/dev-mode.css delete mode 100644 packages/x-components/src/design-system-deprecated/utilities/dev-mode.scss diff --git a/packages/x-components/src/components/animations/cross-fade.vue b/packages/x-components/src/components/animations/cross-fade.vue index 06b6a3940e..d53a2b3dc3 100644 --- a/packages/x-components/src/components/animations/cross-fade.vue +++ b/packages/x-components/src/components/animations/cross-fade.vue @@ -41,7 +41,7 @@ .x-cross-fade--leave-to, .x-cross-fade--enter-from { - opacity: 0; + opacity: 0 !important; } diff --git a/packages/x-components/src/components/animations/staggered-fade-and-slide.vue b/packages/x-components/src/components/animations/staggered-fade-and-slide.vue index 4f187c6fe5..fd46700548 100644 --- a/packages/x-components/src/components/animations/staggered-fade-and-slide.vue +++ b/packages/x-components/src/components/animations/staggered-fade-and-slide.vue @@ -107,7 +107,8 @@ return { name, onEnter, - onAfterEnter + onAfterEnter, + transitionDurationInMs: `${transitionDuration}ms` }; } }); @@ -117,12 +118,12 @@ /* 1. Declare transitions */ .x-staggered-fade-and-slide-enter-active, .x-staggered-fade-and-slide-leave-active { - transition: 250ms ease-out; + transition: v-bind(transitionDurationInMs) ease-out; transition-property: opacity, transform; } .x-staggered-fade-and-slide-move { - transition: transform 250ms ease-out; + transition: transform v-bind(transitionDurationInMs) ease-out; } /* 2. Declare enter, from and leave to state */ diff --git a/packages/x-components/src/components/auto-progress-bar.vue b/packages/x-components/src/components/auto-progress-bar.vue index 094c7c13e3..1548feb8ee 100644 --- a/packages/x-components/src/components/auto-progress-bar.vue +++ b/packages/x-components/src/components/auto-progress-bar.vue @@ -54,7 +54,7 @@ }); - diff --git a/packages/x-components/src/components/layouts/multi-column-max-width-layout.vue b/packages/x-components/src/components/layouts/multi-column-max-width-layout.vue index 62fe313ee5..bb53627668 100644 --- a/packages/x-components/src/components/layouts/multi-column-max-width-layout.vue +++ b/packages/x-components/src/components/layouts/multi-column-max-width-layout.vue @@ -128,7 +128,7 @@ }); - - diff --git a/packages/x-components/src/components/layouts/single-column-layout.vue b/packages/x-components/src/components/layouts/single-column-layout.vue index 8f465b4518..7a077638e8 100644 --- a/packages/x-components/src/components/layouts/single-column-layout.vue +++ b/packages/x-components/src/components/layouts/single-column-layout.vue @@ -110,8 +110,8 @@ }); - diff --git a/packages/x-components/src/design-system-deprecated/utilities/dev-mode.css b/packages/x-components/src/design-system-deprecated/utilities/dev-mode.css new file mode 100644 index 0000000000..8b4b9f0eb9 --- /dev/null +++ b/packages/x-components/src/design-system-deprecated/utilities/dev-mode.css @@ -0,0 +1,12 @@ +.dev-mode .slot-helper { + font-family: inherit; + color: grey; + box-sizing: border-box; + display: flex; + height: 100%; + width: 100%; + justify-content: center; + align-items: center; + border: dashed 1px grey; + border-radius: 10px; +} diff --git a/packages/x-components/src/design-system-deprecated/utilities/dev-mode.scss b/packages/x-components/src/design-system-deprecated/utilities/dev-mode.scss deleted file mode 100644 index 46871cd3ae..0000000000 --- a/packages/x-components/src/design-system-deprecated/utilities/dev-mode.scss +++ /dev/null @@ -1,14 +0,0 @@ -.dev-mode { - .slot-helper { - font-family: inherit; - color: grey; - box-sizing: border-box; - display: flex; - height: 100%; - width: 100%; - justify-content: center; - align-items: center; - border: dashed 1px grey; - border-radius: 10px; - } -} diff --git a/packages/x-components/src/views/ResultApp.vue b/packages/x-components/src/views/ResultApp.vue index 14ba6f8bfc..37ea764ea6 100644 --- a/packages/x-components/src/views/ResultApp.vue +++ b/packages/x-components/src/views/ResultApp.vue @@ -98,7 +98,7 @@ }); - diff --git a/packages/x-components/src/views/accessibility/wai-base-event-button.vue b/packages/x-components/src/views/accessibility/wai-base-event-button.vue index 8654b43156..37afc4eb6d 100644 --- a/packages/x-components/src/views/accessibility/wai-base-event-button.vue +++ b/packages/x-components/src/views/accessibility/wai-base-event-button.vue @@ -27,7 +27,7 @@

BaseResultAddToCart

- + Add to cart
diff --git a/packages/x-components/src/views/home/Home.vue b/packages/x-components/src/views/home/Home.vue index e3f30b6fba..d01d2ad9bb 100644 --- a/packages/x-components/src/views/home/Home.vue +++ b/packages/x-components/src/views/home/Home.vue @@ -690,9 +690,9 @@ +