Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on simplifying the role #4

Open
decentral1se opened this issue Aug 14, 2024 · 0 comments
Open

Thoughts on simplifying the role #4

decentral1se opened this issue Aug 14, 2024 · 0 comments

Comments

@decentral1se
Copy link
Member

I think the role is maybe trying to do too many things. It can bootstrap a VPS, install Decidim but also upgrade an existing Decidim.

Most tech shops have a way to install a VPS and configure DNS the way they like, so I would potentially drop that functionality.

Ansible has historically been bad for dealing with ongoing app maintenance. It shines for server provisioning however. I would drop the "upgrade Decidim" path and remove the need for "complete_install: true/false`. The role then specialises in "install from scratch".

The Redis package is installed via Snap and runs into issues when it tries to restart via systemctl. I would avoid installing via Snap and stick to the system packages.

Some stuff seems "left over" in the role, e.g. vars for matomo. It would be good to look at what vars are still used and what is essential. Perhaps also the sentry stuff is unused?

For a role with this level of complexity (several sub-roles, vars which change the execution flow), I would recommend setting up routine Molecule testing so the role can be guaranteed to be working.

You have several things to test already: Ansible version, Ruby version, Node version and Ubuntu version. And in between all the system dependency versions, e.g. Passenger. Without regular testing, this role can become unreliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant