-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
digitalocean_database_cluster kafka missing attributes #1121
Comments
Thank you for bringing this to our attention. For Kafka, we do not expect those attributes and the provider shouldn't have returned them at all. I've created a ticket internally for our team to ensure the provider only returns the attributes expected from Kafka. I'll keep this issue open until it is addressed. |
If the provider doesn't return them, how, for example port will be known? At least it should be returned, otherwise it will require hardconding it on a client side and if there will be changed in DO kafka deployment (e.g. "private port" will change or so) it will introduce a risk and will require extra testing. Therefore even if port value will be defined on provider level, then two other variables will be easy to construct like |
Apologies, I misspoke. The provider should return these, however, the defaults The database team has made a ticket for the API layer to set the default port to the SASL port to address this and avoid having an empty port value. In the meantime, I'm going to add some documentation around this as well. I also like your suggestion:
We can look into this more as well. |
Bug Report
Describe the bug
Resource
digitalocean_database_cluster
for kafka cluster missing many attributes like:Affected Resource(s)
Expected Behavior
All resources include port, uri and private_uri should be present
Actual Behavior
Port attribute is wrong, other attributes missing
Steps to Reproduce
The text was updated successfully, but these errors were encountered: