From a11e63a9cde4a7dc91e43928b7ab9c33b611658c Mon Sep 17 00:00:00 2001 From: Hendrik Schmidt Date: Fri, 12 Jul 2024 12:34:19 +0200 Subject: [PATCH] Revert "Add plausible error handling" This reverts commit 4e8841f740e863d7478cec880a266ed2bd69fc2d. --- .../dito/app/routes/download.$fileName.tsx | 2 +- ...ergebnis.einschaetzung.$fileName[.pdf].tsx | 5 +--- .../app/routes/vorpruefung.ergebnis/route.tsx | 5 +--- packages/dito/app/utils/trackCustomEvent.ts | 27 +++++++------------ 4 files changed, 13 insertions(+), 26 deletions(-) diff --git a/packages/dito/app/routes/download.$fileName.tsx b/packages/dito/app/routes/download.$fileName.tsx index 41afdc28..fdc98508 100644 --- a/packages/dito/app/routes/download.$fileName.tsx +++ b/packages/dito/app/routes/download.$fileName.tsx @@ -13,7 +13,7 @@ export async function loader({ params, request }: LoaderFunctionArgs) { const filePath = path.join("public", "assets", fileName); const pdfData = await fs.readFile(filePath); - void trackCustomEvent(request, { name: "Download Dokumentation" }); + trackCustomEvent(request, { name: "Download Dokumentation" }); return new Response(pdfData, { status: 200, headers: { diff --git a/packages/dito/app/routes/vorpruefung.ergebnis.einschaetzung.$fileName[.pdf].tsx b/packages/dito/app/routes/vorpruefung.ergebnis.einschaetzung.$fileName[.pdf].tsx index 7a027ed7..b4066507 100644 --- a/packages/dito/app/routes/vorpruefung.ergebnis.einschaetzung.$fileName[.pdf].tsx +++ b/packages/dito/app/routes/vorpruefung.ergebnis.einschaetzung.$fileName[.pdf].tsx @@ -152,10 +152,7 @@ export async function action({ params, request }: ActionFunctionArgs) { } else if (Object.values(answers).find((a) => a === "unsure")) { result = "Unsicher"; } - void trackCustomEvent(request, { - name: "Download Vorprüfung", - props: { result }, - }); + trackCustomEvent(request, { name: "Download Vorprüfung", props: { result } }); return new Response(pdfData, { status: 200, diff --git a/packages/dito/app/routes/vorpruefung.ergebnis/route.tsx b/packages/dito/app/routes/vorpruefung.ergebnis/route.tsx index f4ad6315..72cf89ef 100644 --- a/packages/dito/app/routes/vorpruefung.ergebnis/route.tsx +++ b/packages/dito/app/routes/vorpruefung.ergebnis/route.tsx @@ -36,10 +36,7 @@ export async function loader({ request }: LoaderFunctionArgs) { } else if (unsureQuestions.length > 0) { result = "Unsicher"; } - void trackCustomEvent(request, { - name: "Vorprüfung Resultat", - props: { result }, - }); + trackCustomEvent(request, { name: "Vorprüfung Resultat", props: { result } }); return json({ positiveQuestions, unsureQuestions, negativeQuestions }); } diff --git a/packages/dito/app/utils/trackCustomEvent.ts b/packages/dito/app/utils/trackCustomEvent.ts index cd10c07b..0ff1fdb1 100644 --- a/packages/dito/app/utils/trackCustomEvent.ts +++ b/packages/dito/app/utils/trackCustomEvent.ts @@ -1,7 +1,7 @@ const plausibleUrl = "https://plausible.io/api/event"; const plausibleDomain = "digitalcheck-dito.prod.ds4g.net"; -export default async function trackCustomEvent( +export default function trackCustomEvent( request: Request, event: { name: string; props?: Record }, ) { @@ -9,20 +9,13 @@ export default async function trackCustomEvent( console.log("TRACKING", event); return; } - try { - const response = await fetch(plausibleUrl, { - method: "POST", - body: JSON.stringify({ - domain: plausibleDomain, - url: request.url, - referrer: request.referrer, - ...event, - }), - }); - if (!response.ok) { - throw new Error(`Error tracking event: ${response.status}`); - } - } catch (error) { - console.error("Error tracking event", event, error); - } + void fetch(plausibleUrl, { + method: "POST", + body: JSON.stringify({ + domain: plausibleDomain, + url: request.url, + referrer: request.referrer, + ...event, + }), + }); }