My favorite terrible place

[tshemsedinov]

1. Union type number | undefined is not ok here, why should we pass undefined here?
2. Hardcoded http error codes without names, without named constants
3. Expression code >= 100 && code < 600 in if statement returns boolean itself, so we do not need to use return true/return false
4. Where can we use isHttpCode? Code range have gaps, so this will not validate, see RFC http for reference
   

   be-pkg-utils/src/network.ts

   Lines 50 to 60 in e969374

   	static isHttpCode(code: number | undefined): boolean {
   	if (typeof code !== 'number') {
   	return false
   	}
   	if (code >= 100 && code < 600) {
   	return true
   	}
   	return false
   	}

[tshemsedinov]

Same problem here:

be-pkg-utils/src/network.ts

Lines 62 to 68 in e969374

	static isGrpcCode(code: number | undefined): boolean {
	if (typeof code !== 'number') {
	return false
	}
	return this.grpcStatusCodes.includes(code)
	}

[vird]

Just as an idea, needs reworking to be more matched with code style
#26

[tshemsedinov]

@vird Node.js have status codes collection: https://nodejs.org/api/http.html#httpstatus_codes

[vird]

I'm not sure we can use that here.
Didn't investigate if any other packages are trying to use this one at frontend

[tshemsedinov]

be-* package names is backend @vird

[vird]

Agree
But with webpack any package which was previously named "for backend" can be used on frontend
We have no information about non-released parts of diia