From 36ffbb8499d84662c050ef277e64ff011f582f6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=CC=88rn=20Ro=CC=88der?= Date: Mon, 25 Sep 2017 12:58:06 +0200 Subject: [PATCH 1/2] fixed zero velocity --- lib/jsmidgen.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/jsmidgen.js b/lib/jsmidgen.js index 742222a..ad2928c 100644 --- a/lib/jsmidgen.js +++ b/lib/jsmidgen.js @@ -434,7 +434,7 @@ var Midi = {}; type: MidiEvent.NOTE_ON, channel: channel, param1: Util.ensureMidiPitch(pitch), - param2: velocity || DEFAULT_VOLUME, + param2: velocity !== undefined && typeof velocity === 'number' ? velocity : DEFAULT_VOLUME, time: time || 0, })); return this; From 44a5acdffbc80a4bf201b6e3242bb889e0ac224b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=CC=88rn=20Ro=CC=88der?= Date: Mon, 25 Sep 2017 13:02:14 +0200 Subject: [PATCH 2/2] fixed addNoteOff velocity too --- lib/jsmidgen.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/jsmidgen.js b/lib/jsmidgen.js index ad2928c..84fa25f 100644 --- a/lib/jsmidgen.js +++ b/lib/jsmidgen.js @@ -457,7 +457,7 @@ var Midi = {}; type: MidiEvent.NOTE_OFF, channel: channel, param1: Util.ensureMidiPitch(pitch), - param2: velocity || DEFAULT_VOLUME, + param2: velocity !== undefined && typeof velocity === 'number' ? velocity : DEFAULT_VOLUME, time: time || 0, })); return this;