-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix relative path in the navigation #34
Comments
Done in severals steps, completed in 89404ac |
The code is not working correctly. Reopenning this issue. |
Could you give me an example ? |
The code was not calculating the correct relative path for some files. The problem was trying to do everything with relative paths. It also wasn't adding the correct fragment ID for links to topics within to-content chunks. There was also a bug in the base code that gets the unique topicrefs in that it wasn't handling the case where you have a to-content chunking topicref as a descendant of another to-content chunk--those topics weren't getting processed. I reworked the code so the base navigation structure uses absolute paths, which makes calculating the relative paths easier and more reliable. And I fixed the chunk-handling bug. |
Still have issue:
I am working on it. |
confirmed by travis |
#37 is related |
Proposed fix in 94da8d3. |
I updated the common.xslt module with this new function, so you need to have the latest version of that. |
yes, I figured it but could not get the right path. I am doing tests at this moment. I like the way you use the resultUri variable to resolve the whole thing. There is a file strategy in your code that I have not tested yet. What is it for? |
href
in the navigation use relative path in all situations, like '../concept/topicA.html'.My understanding is that it's not a big problem, it is not super clean implementation but it is a problem when clients have big documentation (over 100 Mo), because all topics in the same directory will have a longer href value which increase documentation size.
The text was updated successfully, but these errors were encountered: