Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rank_plot changes #8

Open
katiedagon opened this issue Aug 25, 2023 · 1 comment
Open

rank_plot changes #8

katiedagon opened this issue Aug 25, 2023 · 1 comment

Comments

@katiedagon
Copy link
Collaborator

katiedagon commented Aug 25, 2023 •
edited
Loading

@djk2120 the modifications to rank_plot and top_n in analysis.py, specifically the indexing by minmax, appear to not work with the OAAT data format being read in by get_exp. I think this has something to do with how the minmax coordinate is set up. Do you have another processed data location for OAAT output that works with the new rank_plot function?
@katiedagon
Copy link
Collaborator Author

katiedagon commented Aug 25, 2023 •
edited
Loading

I found a few more issues with the current analysis.py e.g., reading h1 tape output with get_exp doesn't appear to work anymore.

The rank_plot issue is resolved by switching to the version you have in /glade/u/home/djk2120/ppe_tools - perhaps we could merge those changes into the version in this repo? Reading h1 tape doesn't appear to be fixed by this version though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katiedagon