Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAR shows wrong Ref Area in SPH #140

Open
ghost opened this issue Sep 4, 2022 · 8 comments
Open

FAR shows wrong Ref Area in SPH #140

ghost opened this issue Sep 4, 2022 · 8 comments

Comments

@ghost
Copy link

ghost commented Sep 4, 2022

I have a plane that had Ref Area ~13m2 with previous version of FAR and flew fine (Ok-ish, good enough for what it is).

screenshot3

After installing FAR v0.16.1.0 the same plane has Ref Area ~6m2 and other figures like Cd are also strange.

screenshot4

However, In-flight Ref Area is ~13m2 and the plane flies like before.

screenshot6

@genehwung
Copy link

+1, same issue here.
The FAR analysis UI CoM is incorrect.

@dkavolis
Copy link
Owner

dkavolis commented Sep 5, 2022

Can you provide KSP.log and craft files? I couldn't reproduce the issue with stock parts.

Under the hood, the reference areas both in the editor and in flight are computed the same way by summing S field values from FAR wing modules which is set only from the config. It looks like for some reason S is not being set properly in the editor.

@genehwung
Copy link

I have the RP1 express install through ckan, and just upgrade the FAR through ckan too. The craft file is here.
I don't have access to collect the log now, but I suspect you can reproduce this by just express installing RP1. I followed the instruction here. This might be quickly rule out whether this is RO related issue.

@ghost
Copy link
Author

ghost commented Sep 6, 2022

This is my plane (RP1 required)
Dart.zip

@fluff-li
Copy link

fluff-li commented Sep 6, 2022

The only affected part mentioned in KSP-RO/RealismOverhaul#2718 is also the only one with "forceUseMeshes = true".
Which makes my suspect, that in that case the issue is connected to the recent changes in GeometryPartModule.cs
https://github.com/dkavolis/Ferram-Aerospace-Research/commit/2324be41cd309b4d5957eaa4dd0f52271363899d

The issue in this thread could be connected.

@dkavolis
Copy link
Owner

dkavolis commented Sep 6, 2022

KSP-RO/RealismOverhaul#2718 should be fixed in ba7de8b, was also an issue in stock due to broken Unity serialization which didn't actually serialize the config field.

Can you check if this affects the reference area? https://github.com/dkavolis/Ferram-Aerospace-Research/actions/runs/3002531288

@fluff-li
Copy link

fluff-li commented Sep 7, 2022

The green curve inside SPH looks fixed and reference area number on the runway is the same as inside the Hangar.
The "Mach 1 Wave Drag-Area" is now mostly identical to the initial number from 16.0.5.

Version Mach 1 Wave Drag-Area
0.16.0.5 0.328902 m^2
0.16.1.0 1.70653 m^2
ba7de8b 0.330133 m^2

@genehwung
Copy link

Checked the binary, the reference area and differential numbers seem to be matching now. Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants