Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dub fetch should consider git submodules #1044

Closed
wilzbach opened this issue Jan 8, 2017 · 2 comments
Closed

dub fetch should consider git submodules #1044

wilzbach opened this issue Jan 8, 2017 · 2 comments

Comments

@wilzbach
Copy link
Member

wilzbach commented Jan 8, 2017

If a package has git submodules, they are usually required to build the project.

For example for the Dlang Tour all translations are submodules, see e.g. this issue.

IIRC dub just uses the GitHub archive tool to download a depedency, but I heard (e.g. #632, #104) that there are plans to use e.g. libgit2, s.t. a proper, recursive git clone can be done.

I couldn't find any specific issue for this, but I think it belongs to "native git support" milestone.

@LunaTheFoxgirl
Copy link

LunaTheFoxgirl commented Mar 23, 2018

Idea: Could dub itself check for .gitmodules in the project and its dependencies so that it could fetch the submodules before building everything?

Would be really useful.

@Geod24
Copy link
Member

Geod24 commented Dec 27, 2019

I made a (hopefully complete enough) proposal for submodules support at #1840 .
While that proposal is much bigger than what is described here, I think having half-supported submodules support does not make much sense, so I propose to move the discussion there.
Feel free to re-open and argue if you think this should be a feature / issue of its own :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants