Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should check that grad has correct dtype #20

Open
Guan-t7 opened this issue Oct 3, 2023 · 0 comments
Open

Tests should check that grad has correct dtype #20

Guan-t7 opened this issue Oct 3, 2023 · 0 comments

Comments

@Guan-t7
Copy link

Guan-t7 commented Oct 3, 2023

Many random-float64-promotion complaints from hw2 can be traced to problematic ops implementation in hw1. Given that autograd didn't provide interface to cast Tensor's dtype, the dtype must be consistent from the beginning. Tests for gradient() methods should check that grad.dtype is "smaller" (won't cause promotion) than inputs[i].dtype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant