Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo/Bug in detach function #5

Open
ImadDabbura opened this issue Sep 27, 2022 · 0 comments
Open

Typo/Bug in detach function #5

ImadDabbura opened this issue Sep 27, 2022 · 0 comments

Comments

@ImadDabbura
Copy link

I think there is a bug/typo in https://github.com/dlsyscourse/hw1/blob/master/python/needle/autograd.py#L110:

  • It is supposed to be `return Tensor.make_const(self.realize_cached_data())` not `return Tuple.make_const(self.realize_cached_data())`

I see the same line also in lecture 4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ImadDabbura