-
Notifications
You must be signed in to change notification settings - Fork 38
CRAB Testing
This page describes CRABServer and CRABClient tests executed on each PR in corresponding GitHub repositories. Both CRABServer and CRABClient test can be found in CMSDOCKS Gitlab repository.
All test are executed as Docker containers in DMWM Jenkins. CRABServer tests configuration can be found at https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-CRABServer-PR-test/configure while CRABClient at https://cmssdt.cern.ch/dmwm-jenkins/job/DMWM-CRABClient-PR-test/configure. However, you will need to request access rights to view/edit it. You can do that by writing an email to Shahzad.
After new PR is created, Jenkins generates a report that has 4 sections:
- Pylint;
- Python3 compatibility;
- Default;
- Unit tests.
each of this section has an indication whether that test passed
or failed
. Below all sections are described in more detailed.
Pylint configuration can be found in WMCore repository. So in case you want to run pylint test on your code before creating PR, use this file.
Things in the pylint
report that are bold are causing PR tests to fail. Function which decides if test failed can be found here, while short summary would look like this:
- If pylint report has
warnings
orerrors
, then pylint test fails. However, there is a predefined list of warnings that do not cause pylint test to fail. This list is made of the following warnings:['0511', '0703', '0613']
; - If pylint report score is below 8, then pylint test fails;
"You may see tests as red and with stormy skies (previous builds failed). You shouldn't see the sub-tests mentioned with anything but green and sunny skies."